develop #1

Merged
gitadmin merged 8 commits from develop into master 2026-10-27 09:04:55 +09:00
8 changed files with 107 additions and 5 deletions
Showing only changes of commit 6f1b7423ec - Show all commits

View File

@@ -265,6 +265,26 @@ Before each related task, read the current contents of every matching reference,
If a task spans multiple scopes, read every matching reference. Generated files under `.agent-harness/references/` are read-only copies; edit KriFrontCommon's `.agent/consumer.md` or `.agent/consumer-references/` and recompose instead.
## Noti-hub SMS Types
- `MessageType.SMS = 21`, `LMS = 22`, `MMS = 23`; `ChannelType.SMS = 2` is unchanged. `SMS_TYPE_ARRAY` and `SmsType` include all three.
- `LMS_MMS = 22` remains a deprecated source-compatibility alias for LMS only. It does not represent MMS. Enum reverse lookup for 22 returns LMS. Use numeric bulk-list paths; the server no longer accepts LMS_MMS in paths. Numeric 21/22/23 bulk-list requests all return the entire SMS channel, not type-filtered lists.
- Requests retain their existing URLs/body shapes. The server chooses the actual type per recipient after substitution: attachment -> MMS; otherwise title or UTF-8 body >= 90 bytes -> LMS; otherwise SMS.
- Refresh templates from the save response (`tmplatTy`); display actual delivery types from `sendTy`, not the template or result code. A bulk can contain multiple SMS types. LMS/MMS share result codes; use existing server result labels.
- SMS, LMS, MMS and KKO use cancellation code 9998. Verify with `npm run typecheck`, `npm run build`, and `node --test tests/noti-hub-sms.test.mjs`.
## Noti-hub Reservation Cancellation
- Import cancellation types, constants, and helpers from `@kri/common/noti-hub` only. They are runtime-neutral and require no optional peers.
- Individual current cancellation state is determined by resultCode via isReserveCanceledResult; bulk current state is cancellationStatus (NONE/PARTIAL/ALL). These describe current cancellation state, not cancellation eligibility. cancelDt and cancelUser are request history, not current state.
- SendResultInfo, SendInfo, and BulkSendInfo expose optional cancelable. Use isSendCancelable(item), which returns true only for cancelable === true, for cancellation eligibility; missing values from older responses are treated as false. Never infer eligibility from cancelDt, result labels, or result codes.
- cancelable reflects query-time state and may change before cancellation. Determine the final outcome from SendCancelResponse counts.
- sendIdx is the single-cancel identifier, not cmid. It is absent from the latest abbreviated report (/api/v1/report/last/send/...). Request sendIdx must be a positive integer; bulkSendKey is required and at most 32 characters.
- EMAIL_RESERVE_CANCELED_RESULT_CODE is 108 for EMAIL. SMS_KKO_RESERVE_CANCELED_RESULT_CODE is 9998 for SMS, LMS, MMS, and KKO. Unknown message types are not recognized as canceled.
- Display the server's resultViewLabel/resultLabel ("예약 취소"). There is no separate result-code list API.
- HTTP 200 can contain notCancelableCount. parseSendCancelResponse validates nonnegative integer counts and targetCount = canceledCount + alreadyCanceledCount + notCancelableCount, throwing TypeError on invalid data. Bulk targetCount counts currently registered detail rows; response canceledCount counts only cancellations made by that request.
- Existing response fields are unchanged; all added fields on existing types are optional. Verify with npm run typecheck and npm run build.
## HTTP Streaming
- `@kri/common/http` HTTP clients expose streamGet/streamPost/streamPut/streamPatch/streamDel, returning HttpStreamResponse (status, statusText, headers, url, nullable body).
@@ -288,6 +308,18 @@ When implementing or changing frontend UI, use this order:
- `kri-auto-complete` exposes `resetScrollOnSearch?: boolean` on `KriSingleSelect`, `KriMultiSelect`, and `MultiSelect`. It defaults to `false`, preserving existing behavior.
- When enabled, a search value change (including clearing it) resets the option list scroll to the top on the next animation frame in both `filter` and `inputOnly` modes. Async result updates alone do not trigger another reset.
### KriAutoComplete Option Tooltip
- `kri-auto-complete` exposes `optionTooltip?: 'singleLine' | 'wrap'` and `optionTooltipClassName?: string` on `KriSingleSelect`, `KriMultiSelect`, and `MultiSelect`. It is off by default, preserving existing behavior.
- When enabled, hovering an option shows its full `label` in a right-side tooltip. `singleLine` stays on one line until the available viewport width; `wrap` wraps at 28rem. The item depends on the shadcn `tooltip` component and provides its own `TooltipProvider`.
### KriEditor SMS Preview
- `changeSmsType` reports `SMS | LMS | MMS`. Update consumer callbacks to handle `MMS`; this widens the previous callback contract.
- Attachment presence (`smsHasAttachment`) takes priority and reports MMS. Otherwise a title or UTF-8 preview size >= `smsMaxBytes` (default 90) reports LMS; the remainder reports SMS. LMS/MMS share `lmsMaxBytes` (default 2000).
- UTF-8 byte counting includes `smsPreviewSuffix` and its separating newline, without storing the suffix in the body.
- This is a preview. Use the template-save response for saved `tmplatTy` and delivery-result `sendTy` for actual per-recipient type after server substitution. Registry updates require updating installed consumer copies.
### Required Shared References
Before each related task, read the current contents of every matching reference, even if it was read earlier in the session.

View File

@@ -3,9 +3,9 @@
import * as React from 'react'
import { cn } from '@/lib/utils'
import { MultiSelect } from '@/components/common/multi-select'
import type { MultiSelectOption, MultiSelectRef } from '@/components/common/multi-select'
import type { MultiSelectOption, MultiSelectOptionTooltip, MultiSelectRef } from '@/components/common/multi-select'
export type { MultiSelectOption, MultiSelectRef } from '@/components/common/multi-select'
export type { MultiSelectOption, MultiSelectOptionTooltip, MultiSelectRef } from '@/components/common/multi-select'
export interface KriAutoCompleteBaseProps<T> {
items: T[]
@@ -26,6 +26,8 @@ export interface KriAutoCompleteBaseProps<T> {
disabled?: boolean
'aria-invalid'?: boolean
modalPopover?: boolean
optionTooltip?: MultiSelectOptionTooltip
optionTooltipClassName?: string
}
export interface KriMultiSelectProps<T = unknown> extends KriAutoCompleteBaseProps<T> {
@@ -77,6 +79,8 @@ export function KriMultiSelect<T = unknown>({
disabled,
'aria-invalid': ariaInvalid,
modalPopover = true,
optionTooltip,
optionTooltipClassName,
}: KriMultiSelectProps<T>) {
const options = React.useMemo(
() => toOptions(items, getValue, getLabel, withInfo),
@@ -110,6 +114,8 @@ export function KriMultiSelect<T = unknown>({
disabled={disabled}
aria-invalid={ariaInvalid}
modalPopover={modalPopover}
optionTooltip={optionTooltip}
optionTooltipClassName={optionTooltipClassName}
/>
</div>
)
@@ -157,6 +163,8 @@ function KriSingleSelectInner<T>({
disabled,
'aria-invalid': ariaInvalid,
modalPopover = true,
optionTooltip,
optionTooltipClassName,
}: KriSingleSelectProps<T>, forwardedRef: React.ForwardedRef<MultiSelectRef>) {
const ref = React.useRef<MultiSelectRef>(null)
React.useImperativeHandle(
@@ -227,6 +235,8 @@ function KriSingleSelectInner<T>({
aria-invalid={ariaInvalid}
title={showSelectedTooltip ? selectedLabel ?? value : undefined}
modalPopover={modalPopover}
optionTooltip={optionTooltip}
optionTooltipClassName={optionTooltipClassName}
/>
</div>
)

View File

@@ -46,6 +46,8 @@ function MultiSelectInner<T>(
closeOnSelect = false,
preventDeselect = false,
hideOptionCheck = false,
optionTooltip,
optionTooltipClassName,
style,
...buttonProps
}: MultiSelectProps<T>,
@@ -205,6 +207,8 @@ function MultiSelectInner<T>(
onSearchValueChange={handleSearchChange}
hideSelectAll={hideSelectAll}
hideOptionCheck={hideOptionCheck}
optionTooltip={optionTooltip}
optionTooltipClassName={optionTooltipClassName}
selectionMode={selectionMode}
emptyIndicator={emptyIndicator}
onToggleOption={toggleOption}

View File

@@ -11,8 +11,9 @@ import {
CommandList,
CommandSeparator,
} from '@/components/ui/command'
import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip'
import { cn } from '@/lib/utils'
import type { MultiSelectGroup, MultiSelectOption, MultiSelectOptions } from './types'
import type { MultiSelectGroup, MultiSelectOption, MultiSelectOptionTooltip, MultiSelectOptions } from './types'
import { isGroupedOptions } from './utils'
interface MultiSelectContentProps<T> {
@@ -25,25 +26,57 @@ interface MultiSelectContentProps<T> {
onSearchValueChange: (value: string) => void
hideSelectAll: boolean
hideOptionCheck: boolean
optionTooltip?: MultiSelectOptionTooltip
optionTooltipClassName?: string
selectionMode: 'single' | 'multiple'
emptyIndicator: React.ReactNode
onToggleOption: (option: MultiSelectOption<T>) => void
onToggleAll: () => void
}
interface OptionTooltipSettings {
mode: MultiSelectOptionTooltip
className?: string
}
function OptionItem<T>({
option,
selected,
hideOptionCheck,
tooltip,
onToggle,
}: {
option: MultiSelectOption<T>
selected: boolean
hideOptionCheck: boolean
tooltip?: OptionTooltipSettings
onToggle: () => void
}) {
const Icon = option.icon
// cmdk's CommandItem overrides onPointerMove, so the label (not the item) is the tooltip trigger.
const label = tooltip ? (
<Tooltip>
<TooltipTrigger asChild>
<span className="min-w-0 flex-1 truncate">{option.label}</span>
</TooltipTrigger>
<TooltipContent
side="right"
className={cn(
'break-words',
tooltip.mode === 'wrap'
? 'max-w-[min(28rem,var(--radix-tooltip-content-available-width))]'
: 'max-w-[var(--radix-tooltip-content-available-width)]',
tooltip.className,
)}
>
{option.label}
</TooltipContent>
</Tooltip>
) : (
<span className="truncate">{option.label}</span>
)
return (
<CommandItem
value={`${option.label} ${option.value}`}
@@ -62,7 +95,7 @@ function OptionItem<T>({
</span>
) : null}
{Icon ? <Icon className="size-4" style={{ color: option.style?.iconColor }} /> : null}
<span className="truncate">{option.label}</span>
{label}
</CommandItem>
)
}
@@ -71,11 +104,13 @@ function OptionsGroup<T>({
group,
selectedValues,
hideOptionCheck,
tooltip,
onToggleOption,
}: {
group: MultiSelectGroup<T>
selectedValues: string[]
hideOptionCheck: boolean
tooltip?: OptionTooltipSettings
onToggleOption: (option: MultiSelectOption<T>) => void
}) {
return (
@@ -86,6 +121,7 @@ function OptionsGroup<T>({
option={option}
selected={selectedValues.includes(option.value)}
hideOptionCheck={hideOptionCheck}
tooltip={tooltip}
onToggle={() => onToggleOption(option)}
/>
))}
@@ -103,6 +139,8 @@ export function MultiSelectContent<T>({
onSearchValueChange,
hideSelectAll,
hideOptionCheck,
optionTooltip,
optionTooltipClassName,
selectionMode,
emptyIndicator,
onToggleOption,
@@ -123,8 +161,9 @@ export function MultiSelectContent<T>({
const flatOptions = grouped ? options.flatMap((group) => group.options) : options
const selectableOptions = flatOptions.filter((option) => !option.disabled)
const allSelected = selectableOptions.length > 0 && selectableOptions.every((option) => selectedValues.includes(option.value))
const tooltip = optionTooltip ? { mode: optionTooltip, className: optionTooltipClassName } : undefined
return (
const content = (
<Command shouldFilter={searchMode === 'filter'}>
{searchable ? (
<CommandInput
@@ -161,6 +200,7 @@ export function MultiSelectContent<T>({
group={group}
selectedValues={selectedValues}
hideOptionCheck={hideOptionCheck}
tooltip={tooltip}
onToggleOption={onToggleOption}
/>
))
@@ -172,6 +212,7 @@ export function MultiSelectContent<T>({
option={option}
selected={selectedValues.includes(option.value)}
hideOptionCheck={hideOptionCheck}
tooltip={tooltip}
onToggle={() => onToggleOption(option)}
/>
))}
@@ -180,4 +221,6 @@ export function MultiSelectContent<T>({
</CommandList>
</Command>
)
return tooltip ? <TooltipProvider delayDuration={0}>{content}</TooltipProvider> : content
}

View File

@@ -3,6 +3,7 @@ export type {
AnimationConfig,
MultiSelectGroup,
MultiSelectOption,
MultiSelectOptionTooltip,
MultiSelectOptions,
MultiSelectProps,
MultiSelectRef,

View File

@@ -29,6 +29,7 @@ export interface MultiSelectGroup<T = unknown> {
export type MultiSelectOptions<T = unknown> = MultiSelectOption<T>[] | MultiSelectGroup<T>[]
export type MultiSelectSelectionMode = 'single' | 'multiple'
export type MultiSelectVariant = 'default' | 'secondary' | 'destructive' | 'inverted'
export type MultiSelectOptionTooltip = 'singleLine' | 'wrap'
export interface MultiSelectResponsiveSettings {
maxCount?: number
@@ -79,6 +80,8 @@ export interface MultiSelectProps<T = unknown>
closeOnSelect?: boolean
preventDeselect?: boolean
hideOptionCheck?: boolean
optionTooltip?: MultiSelectOptionTooltip
optionTooltipClassName?: string
}
export interface MultiSelectRef {

View File

@@ -50,6 +50,9 @@ export function ProjectSelector() {
spanClassName="text-sm [&_span]:text-kart-text"
searchable
resetScrollOnSearch
// Legacy react-tooltip: full "(pkey) title" on hover, right side, 65% opacity.
optionTooltip="singleLine"
optionTooltipClassName="opacity-65"
preventDeselect
hideOptionCheck
disabled={projects.isPending}

View File

@@ -245,6 +245,9 @@ function FilterLineRow({
searchable
preventDeselect
hideOptionCheck
// Legacy QuestionSelect tooltip: full title on hover.
optionTooltip="singleLine"
optionTooltipClassName="opacity-65"
onChange={(qid) => {
const selected = questions.find((item) => item.qid === qid);
if (!selected) return;
@@ -302,6 +305,9 @@ function FilterLineRow({
badgeClassName="text-xs"
maxSelected={multi ? undefined : 1}
hideSelectAll={!multi}
// Legacy ValueSelect tooltip: full label on hover.
optionTooltip="singleLine"
optionTooltipClassName="opacity-65"
onChange={(next) => {
// Legacy keeps codes sorted and comma-joined.
const value = [...next].sort().join(",");