From 444ddb35e65912b098840ae6b520f6c3c7a4773b Mon Sep 17 00:00:00 2001 From: kric_jspark Date: Thu, 13 Aug 2026 09:57:19 +0900 Subject: [PATCH] fix: support Korean project paths on Windows --- package-lock.json | 4 +-- package.json | 2 +- templates/base/build.gradle | 8 ++++++ templates/base/gradle.properties | 4 ++- tests/harness.test.mjs | 8 +++--- tests/path-safety.test.mjs | 44 ++++++++++++++++++++++++++++++++ 6 files changed, 62 insertions(+), 8 deletions(-) create mode 100644 tests/path-safety.test.mjs diff --git a/package-lock.json b/package-lock.json index 0bfa528..43cea46 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@kri/create-spring-app", - "version": "0.1.4", + "version": "0.1.5", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@kri/create-spring-app", - "version": "0.1.4", + "version": "0.1.5", "license": "UNLICENSED", "bin": { "kri-create-spring-app": "dist/cli.js" diff --git a/package.json b/package.json index 597b2bf..a4bebce 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@kri/create-spring-app", - "version": "0.1.4", + "version": "0.1.5", "description": "Create a KRI standard Spring Boot application", "type": "module", "bin": { diff --git a/templates/base/build.gradle b/templates/base/build.gradle index 8297872..b6a7d3c 100644 --- a/templates/base/build.gradle +++ b/templates/base/build.gradle @@ -84,6 +84,14 @@ tasks.withType(JavaCompile).configureEach { options.generatedSourceOutputDirectory.set(file(querydslDir)) } +tasks.withType(Test).configureEach { + jvmArgs '-Dfile.encoding=UTF-8' +} + +tasks.withType(JavaExec).configureEach { + jvmArgs '-Dfile.encoding=UTF-8' +} + tasks.named('test') { useJUnitPlatform() } diff --git a/templates/base/gradle.properties b/templates/base/gradle.properties index a31b0e0..0e829de 100644 --- a/templates/base/gradle.properties +++ b/templates/base/gradle.properties @@ -1,3 +1,5 @@ -org.gradle.jvmargs=-Xmx2g -Dfile.encoding=UTF-8 +# Keep the Gradle daemon on the platform charset so Windows JDK 17 can read +# worker classpath files containing non-ASCII project paths. +org.gradle.jvmargs=-Xmx2g org.gradle.parallel=true org.gradle.caching=true diff --git a/tests/harness.test.mjs b/tests/harness.test.mjs index d3a271f..6ce0f75 100644 --- a/tests/harness.test.mjs +++ b/tests/harness.test.mjs @@ -8,9 +8,9 @@ import { parseArguments } from "../dist/args.js"; import { composeAgentHarness } from "../dist/harness.js"; async function createFixture(t) { - const root = await mkdtemp(path.join(os.tmpdir(), "kri-create-spring-harness-")); - const harnessRoot = path.join(root, "_________AgentHarnessBase"); - const targetDir = path.join(root, "sample-server"); + const root = await mkdtemp(path.join(os.tmpdir(), "kri-create-spring-한글 공백-")); + const harnessRoot = path.join(root, "_________Agent Harness 기준"); + const targetDir = path.join(root, "샘플 server"); const logPath = path.join(root, "calls.jsonl"); await mkdir(path.join(harnessRoot, "dist"), { recursive: true }); await mkdir(targetDir, { recursive: true }); @@ -52,7 +52,7 @@ test("registers shared, composes, and verifies in deterministic order", async (t .split("\n") .map((line) => JSON.parse(line)); assert.deepEqual(calls, [ - ["register", "--project", "sample-server", "--path", "sample-server", "--shared"], + ["register", "--project", "sample-server", "--path", "샘플 server", "--shared"], ["compose", "--project", "sample-server"], ["verify", "--project", "sample-server"], ]); diff --git a/tests/path-safety.test.mjs b/tests/path-safety.test.mjs new file mode 100644 index 0000000..9631ab2 --- /dev/null +++ b/tests/path-safety.test.mjs @@ -0,0 +1,44 @@ +import assert from "node:assert/strict"; +import { mkdtemp, mkdir, readFile, rm } from "node:fs/promises"; +import os from "node:os"; +import path from "node:path"; +import test from "node:test"; +import { fileURLToPath } from "node:url"; + +import { run } from "../dist/process.js"; + +const repositoryRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), ".."); + +test("keeps Gradle worker paths compatible with Windows JDK 17", async () => { + const gradleProperties = await readFile( + path.join(repositoryRoot, "templates", "base", "gradle.properties"), + "utf8", + ); + const buildGradle = await readFile( + path.join(repositoryRoot, "templates", "base", "build.gradle"), + "utf8", + ); + + assert.doesNotMatch( + gradleProperties, + /org\.gradle\.jvmargs=.*-Dfile\.encoding=/, + "Gradle daemon encoding must remain platform-compatible for worker classpath files", + ); + assert.match(buildGradle, /tasks\.withType\(JavaCompile\)[\s\S]*options\.encoding = 'UTF-8'/); + assert.match(buildGradle, /tasks\.withType\(Test\)[\s\S]*jvmArgs '-Dfile\.encoding=UTF-8'/); + assert.match(buildGradle, /tasks\.withType\(JavaExec\)[\s\S]*jvmArgs '-Dfile\.encoding=UTF-8'/); +}); + +test("runs a child process from a Korean path containing spaces", async (t) => { + const root = await mkdtemp(path.join(os.tmpdir(), "kri-create-spring-한글 공백-")); + const targetDir = path.join(root, "생성 프로젝트"); + await mkdir(targetDir, { recursive: true }); + t.after(() => rm(root, { recursive: true, force: true })); + + const markerName = "실행 결과.txt"; + const script = `require("node:fs").writeFileSync(${JSON.stringify(markerName)}, process.cwd(), "utf8")`; + const nodeCommand = process.platform === "win32" ? path.basename(process.execPath) : process.execPath; + await run(nodeCommand, ["-e", script], targetDir); + + assert.equal(await readFile(path.join(targetDir, markerName), "utf8"), targetDir); +});