[SonarQube][FindBugs] duplicating this literal, Stream.toList(), TODO, Unused "private" methods should be removed

This commit is contained in:
김현주
2025-07-21 15:47:38 +09:00
parent 0be90dc915
commit 3e1817a991
21 changed files with 70 additions and 74 deletions

View File

@@ -49,7 +49,7 @@ class GetNoticeDao implements GetNoticePortOut {
return uploadFile;
})
.collect(Collectors.toList()));
.toList());
return Optional.of(secArticle);
}

View File

@@ -1,6 +1,7 @@
package app.module.admin.usecase.communication.notice.getNotice.adapters.web;
import app.module.admin.usecase.communication.notice.getNotice.ports.GetNoticePortIn;
import app.module.admin.usecase.communication.notice.getNotice.ports.application.domain.GetNotice;
import app.module.admin.usecase.communication.notice.getNotice.ports.application.domain.GetNoticeCmd;
import lombok.RequiredArgsConstructor;
import org.springframework.http.HttpStatus;
@@ -15,7 +16,7 @@ class GetNoticeController {
private final GetNoticePortIn getNoticePortIn;
@GetMapping(path = "/api/communication/notices/{id}")
ResponseEntity<?> operate(@PathVariable Long id) {
ResponseEntity<GetNotice> operate(@PathVariable Long id) {
return ResponseEntity.status(HttpStatus.OK)
.body(getNoticePortIn.operate(new GetNoticeCmd(id)).orElseThrow());
}