Merge pull request '261103_01_ENH: 공연 상세 관계자 정보 유형별 빈 행 표시 및 단체(인)명 수정 가능하도록 개선' (#19) from develop into master

Reviewed-on: #19
This commit is contained in:
2026-11-03 16:13:06 +09:00
2 changed files with 164 additions and 9 deletions

View File

@@ -230,6 +230,7 @@ When implementation is complete, report in Korean:
- Treat the current React version, component style, state management, routing, styling, and test approach as authoritative.
- Do not perform unrelated class-to-hook, JavaScript-to-TypeScript, state-library, styling-system, or React-to-Next.js migrations.
- Keep components focused and follow the repository's established split between presentation, state, data access, and side effects.
- Do not use nested ternary expressions. Use clear `if`/`else` branches, early returns, or well-named intermediate variables instead; a single, non-nested ternary is acceptable only when it remains immediately readable.
- Keep effects dependency-correct and clean up subscriptions, timers, listeners, and in-flight work where applicable.
- Use stable semantic keys and preserve accessibility, loading, empty, error, disabled, and success states.
- Preserve public component props and shared UI contracts unless a coordinated breaking change is explicitly approved.
@@ -266,6 +267,35 @@ Before each related task, read the current contents of every matching reference,
If a task spans multiple scopes, read every matching reference. Generated files under `.agent-harness/references/` are read-only copies; edit KriFrontCommon's `.agent/consumer.md` or `.agent/consumer-references/` and recompose instead.
## Noti-hub SMS Types
- `MessageType.SMS = 21`, `LMS = 22`, `MMS = 23`; `ChannelType.SMS = 2` is unchanged. `SMS_TYPE_ARRAY` and `SmsType` include all three.
- `LMS_MMS = 22` remains a deprecated source-compatibility alias for LMS only. It does not represent MMS. Enum reverse lookup for 22 returns LMS. Use numeric bulk-list paths; the server no longer accepts LMS_MMS in paths. Numeric 21/22/23 bulk-list requests all return the entire SMS channel, not type-filtered lists.
- Requests retain their existing URLs/body shapes. The server chooses the actual type per recipient after substitution: attachment -> MMS; otherwise title or UTF-8 body >= 90 bytes -> LMS; otherwise SMS.
- Refresh templates from the save response (`tmplatTy`); display actual delivery types from `sendTy`, not the template or result code. A bulk can contain multiple SMS types. LMS/MMS share result codes; use existing server result labels.
- SMS, LMS, MMS and KKO use cancellation code 9998. Verify with `npm run typecheck`, `npm run build`, and `node --test tests/noti-hub-sms.test.mjs`.
## Noti-hub Reservation Cancellation
- Import cancellation types, constants, and helpers from `@kri/common/noti-hub` only. They are runtime-neutral and require no optional peers.
- Individual current cancellation state is determined by resultCode via isReserveCanceledResult; bulk current state is cancellationStatus (NONE/PARTIAL/ALL). These describe current cancellation state, not cancellation eligibility. cancelDt and cancelUser are request history, not current state.
- SendResultInfo, SendInfo, and BulkSendInfo expose optional cancelable. Use isSendCancelable(item), which returns true only for cancelable === true, for cancellation eligibility; missing values from older responses are treated as false. Never infer eligibility from cancelDt, result labels, or result codes.
- cancelable reflects query-time state and may change before cancellation. Determine the final outcome from SendCancelResponse counts.
- sendIdx is the single-cancel identifier, not cmid. It is absent from the latest abbreviated report (/api/v1/report/last/send/...). Request sendIdx must be a positive integer; bulkSendKey is required and at most 32 characters.
- EMAIL_RESERVE_CANCELED_RESULT_CODE is 108 for EMAIL. SMS_KKO_RESERVE_CANCELED_RESULT_CODE is 9998 for SMS, LMS, MMS, and KKO. Unknown message types are not recognized as canceled.
- Display the server's resultViewLabel/resultLabel ("예약 취소"). There is no separate result-code list API.
- HTTP 200 can contain notCancelableCount. parseSendCancelResponse validates nonnegative integer counts and targetCount = canceledCount + alreadyCanceledCount + notCancelableCount, throwing TypeError on invalid data. Bulk targetCount counts currently registered detail rows; response canceledCount counts only cancellations made by that request.
- Existing response fields are unchanged; all added fields on existing types are optional. Verify with npm run typecheck and npm run build.
## HTTP Streaming
- `@kri/common/http` HTTP clients expose streamGet/streamPost/streamPut/streamPatch/streamDel, returning HttpStreamResponse (status, statusText, headers, url, nullable body).
- Streaming shares ordinary authentication, URL, body and HTTP-error policy. Read body incrementally; no automatic JSON/NDJSON/SSE parsing or reconnect is performed.
- Streaming options accept an external AbortSignal. Caller cancellation raises AbortError without an HTTP error notification. Cancel the body when it will not be consumed.
- timeoutMs covers connection/headers (and an HTTP error body); idleTimeoutMs covers inactivity after successful headers and resets on consumed chunks. Both default to the client's defaultTimeoutMs (60 seconds by default), and 0 disables that timer for streaming only.
- Mid-stream transport/time-out errors reach the body reader. HTTP error statuses use existing HttpError handlers before a stream is returned. A 204 response has body=null.
- See HTTP_STREAMING.md for examples and node --test tests/http-stream.test.mjs for focused validation after npm run build.
## KriUiRegistry Consumer Contract
When implementing or changing frontend UI, use this order:
@@ -275,6 +305,28 @@ When implementing or changing frontend UI, use this order:
3. Otherwise, prefer a suitable shadcn/ui component.
4. Create a custom component only when the preceding options cannot meet the requirement safely.
### KriAutoComplete Search Scroll
- `kri-auto-complete` exposes `resetScrollOnSearch?: boolean` on `KriSingleSelect`, `KriMultiSelect`, and `MultiSelect`. It defaults to `false`, preserving existing behavior.
- When enabled, a search value change (including clearing it) resets the option list scroll to the top on the next animation frame in both `filter` and `inputOnly` modes. Async result updates alone do not trigger another reset.
### KriAutoComplete Option Tooltip
- `kri-auto-complete` exposes `optionTooltip?: 'singleLine' | 'wrap'` and `optionTooltipClassName?: string` on `KriSingleSelect`, `KriMultiSelect`, and `MultiSelect`. It is off by default, preserving existing behavior.
- When enabled, hovering an option shows its full `label` in a right-side tooltip. `singleLine` stays on one line until the available viewport width; `wrap` wraps at 28rem. The item depends on the shadcn `tooltip` component and provides its own `TooltipProvider`.
### KriAutoComplete Search Match
- `kri-auto-complete` exposes `searchMatch?: 'fuzzy' | 'contains'` on `KriSingleSelect`, `KriMultiSelect`, and `MultiSelect`. It defaults to `fuzzy` (cmdk's default subsequence scoring), preserving existing behavior.
- `contains` keeps only options whose label or value contains the search text as a case-insensitive substring, in the original option order. It applies only when `searchMode` is `filter`.
### KriEditor SMS Preview
- `changeSmsType` reports `SMS | LMS | MMS`. Update consumer callbacks to handle `MMS`; this widens the previous callback contract.
- Attachment presence (`smsHasAttachment`) takes priority and reports MMS. Otherwise a title or UTF-8 preview size >= `smsMaxBytes` (default 90) reports LMS; the remainder reports SMS. LMS/MMS share `lmsMaxBytes` (default 2000).
- UTF-8 byte counting includes `smsPreviewSuffix` and its separating newline, without storing the suffix in the body.
- This is a preview. Use the template-save response for saved `tmplatTy` and delivery-result `sendTy` for actual per-recipient type after server substitution. Registry updates require updating installed consumer copies.
### Required Shared References
Before each related task, read the current contents of every matching reference, even if it was read earlier in the session.

View File

@@ -58,6 +58,66 @@ type PerformanceDetail = PerformanceCompact["performanceDetail"];
type MonitoringVisitResetStatus = "departure" | "arrival";
const DETAIL_TEXT_MAX_LENGTH = 2048;
const ARTIST_NAME_MAX_LENGTH = 128;
type StaffTextField = "staffName" | "staffTel1" | "staffTel2" | "staffEmail";
// DB 컬럼 길이와 맞춘다.
const STAFF_FIELD_MAX_LENGTH: Record<StaffTextField, number> = {
staffName: 32,
staffTel1: 32,
staffTel2: 32,
staffEmail: 128,
};
const STAFF_TEXT_FIELDS: StaffTextField[] = ["staffName", "staffTel1", "staffTel2", "staffEmail"];
type StaffRow = {
key: string;
// null이면 유형 코드가 없어 입력할 수 없는 빈 행이다.
staffType: number | null;
staff: PerformanceStaff | null;
index: number | null;
};
const isBlankStaff = (staff: PerformanceStaff) => STAFF_TEXT_FIELDS.every((field) => (staff[field] ?? "").trim() === "");
// 관계자 유형 코드마다 행을 만들고, 데이터가 없는 유형은 빈 행으로 채운다.
// 빈 행과 새로 입력한 관계자는 같은 key를 사용해 입력 중 포커스가 유지되게 한다.
const buildStaffRows = (staffList: PerformanceStaff[], staffCodes: Code[]): StaffRow[] => {
const toRow = (staff: PerformanceStaff, index: number): StaffRow => ({
key: staff.id > 0 ? `staff-${staff.id}` : `new-${staff.staffType}`,
staffType: staff.staffType,
staff,
index,
});
const rows: StaffRow[] = [];
const usedIndexes = new Set<number>();
staffCodes.forEach((code) => {
const matched = staffList
.map((staff, index) => ({staff, index}))
.filter(({staff}) => staff.staffType === code.codeValue);
if (matched.length === 0) {
rows.push({key: `new-${code.codeValue}`, staffType: code.codeValue, staff: null, index: null});
return;
}
matched.forEach(({staff, index}) => {
usedIndexes.add(index);
rows.push(toRow(staff, index));
});
});
staffList.forEach((staff, index) => {
if (!usedIndexes.has(index)) rows.push(toRow(staff, index));
});
if (rows.length === 0) {
rows.push({key: "empty", staffType: null, staff: null, index: null});
}
return rows;
};
// UpdateNoticeDt는 한국시간 ISO 문자열이므로 시간대 변환 없이 표시만 정리한다.
const formatUpdateNoticeDt = (value?: string) => (value ?? "").replace("T", " ").replace(/\.\d+/, "");
@@ -523,6 +583,39 @@ export function PerformanceDetailDialog({
});
};
const updateStaffRow = (row: StaffRow, key: StaffTextField, value: string) => {
if (row.index !== null) {
updateStaff(row.index, key, value);
return;
}
const staffType = row.staffType;
if (staffType === null) return;
setDraft((prev) => {
if (!prev) return prev;
// id는 서버에서 새로 발급하므로 0으로 보낸다.
const newStaff: PerformanceStaff = {
id: 0,
performanceId: prev.id,
staffType,
staffName: "",
staffTel1: "",
staffTel2: "",
staffEmail: "",
[key]: value,
};
return {...prev, performanceStaff: [...(prev.performanceStaff ?? []), newStaff]};
});
};
const renderStaffCell = (row: StaffRow, field: StaffTextField) => {
const value = row.staff?.[field] ?? "";
if (!isEditing || row.staffType === null) return value;
return <Input maxLength={STAFF_FIELD_MAX_LENGTH[field]} value={value} onChange={(event) => updateStaffRow(row, field, event.target.value)} />;
};
const staffRows = draft ? buildStaffRows(draft.performanceStaff ?? [], codes.staff_type ?? []) : [];
const resetDraft = () => {
if (!performance) return;
setDraft({
@@ -564,6 +657,17 @@ export function PerformanceDetailDialog({
alert(`${PERFORMANCE_FIELD_LABELS.UpdateNoticeTarget}을 선택한 경우 ${PERFORMANCE_FIELD_LABELS.UpdateNoticeMemo}을 입력해 주세요.`);
return;
}
if ((draft.artistName ?? "").trim() === "") {
alert(`${PERFORMANCE_FIELD_LABELS.artistName}을 입력해 주세요.`);
return;
}
// 모든 칸이 공란인 관계자는 저장하지 않는다.
const performanceStaff = (draft.performanceStaff ?? []).filter((staff) => !isBlankStaff(staff));
if (performanceStaff.some((staff) => (staff.staffName ?? "").trim() === "")) {
alert("관계자 이름을 입력해 주세요.");
return;
}
const performanceDetail: PerformanceDetail = {
...detail,
@@ -574,7 +678,7 @@ export function PerformanceDetailDialog({
// 변경 일시는 서버에서 생성하므로 요청에서 제외한다.
delete performanceDetail["UpdateNoticeDt"];
onSave?.({...draft, performanceDetail});
onSave?.({...draft, performanceDetail, performanceStaff});
setIsEditing(false);
};
@@ -614,7 +718,7 @@ export function PerformanceDetailDialog({
) : getCodeLabel(codes, "area", draft.performanceArea)}
</DetailRow>
<DetailRow label={PERFORMANCE_FIELD_LABELS.performanceAreaDetail}>{isEditing ? <Input value={draft.performanceDetail["performanceAreaDetail"] ?? ""} onChange={(event) => updateDetail("performanceAreaDetail", event.target.value)} /> : draft.performanceDetail["performanceAreaDetail"] ?? ""}</DetailRow>
<DetailRow label={PERFORMANCE_FIELD_LABELS.artistName}>{draft.artistName}</DetailRow>
<DetailRow label={PERFORMANCE_FIELD_LABELS.artistName}>{isEditing ? <Input maxLength={ARTIST_NAME_MAX_LENGTH} value={draft.artistName ?? ""} onChange={(event) => updateDraft("artistName", event.target.value)} /> : draft.artistName}</DetailRow>
<DetailRow label={PERFORMANCE_FIELD_LABELS.performanceName}>{isEditing ? <Input value={draft.performanceName} onChange={(event) => updateDraft("performanceName", event.target.value)} /> : draft.performanceName}</DetailRow>
<DetailRow label={PERFORMANCE_FIELD_LABELS.performanceStartMonth}>{isEditing ? <Input type="number" value={draft.performanceStartMonth} onChange={(event) => updateDraft("performanceStartMonth", Number(event.target.value))} /> : `${draft.performanceStartMonth}월`}</DetailRow>
<DetailRow label={PERFORMANCE_FIELD_LABELS.performanceDtInfo}>{isEditing ? <Input value={draft.performanceDtInfo} onChange={(event) => updateDraft("performanceDtInfo", event.target.value)} /> : draft.performanceDtInfo}</DetailRow>
@@ -676,13 +780,12 @@ export function PerformanceDetailDialog({
</tr>
</thead>
<tbody>
{draft.performanceStaff?.map((staff, index) => (
<tr key={staff.id}>
<td className="border p-2">{getCodeLabel(codes, "staff_type", staff.staffType)}</td>
<td className="border p-2">{isEditing ? <Input value={staff.staffName} onChange={(event) => updateStaff(index, "staffName", event.target.value)} /> : staff.staffName}</td>
<td className="border p-2">{isEditing ? <Input value={staff.staffTel1} onChange={(event) => updateStaff(index, "staffTel1", event.target.value)} /> : staff.staffTel1}</td>
<td className="border p-2">{isEditing ? <Input value={staff.staffTel2} onChange={(event) => updateStaff(index, "staffTel2", event.target.value)} /> : staff.staffTel2}</td>
<td className="border p-2">{isEditing ? <Input value={staff.staffEmail} onChange={(event) => updateStaff(index, "staffEmail", event.target.value)} /> : staff.staffEmail}</td>
{staffRows.map((row) => (
<tr key={row.key}>
<td className="h-9 border p-2">{getCodeLabel(codes, "staff_type", row.staffType)}</td>
{STAFF_TEXT_FIELDS.map((field) => (
<td key={field} className="border p-2">{renderStaffCell(row, field)}</td>
))}
</tr>
))}
</tbody>